Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add rule for reg.present to use integers for REG_DWORD #110

Closed
flassman opened this issue Nov 14, 2019 · 4 comments
Closed
Labels

Comments

@flassman
Copy link

reg.present can take strings as input for REG_DWORD values, however the state then does not detect if the value is already set correctly, see saltstack/salt#55284

HKEY_LOCAL_MACHINE:
  reg.present:
    - vname: MyTest
    - vtype: REG_DWORD
    - vdata: '00000001'

so to be in the safe side, the REG_DWORD should be used with integers in vdata like this:

HKEY_LOCAL_MACHINE:
  reg.present:
    - vname: MyTest
    - vtype: REG_DWORD
    - vdata: 1
@roaldnefs roaldnefs added Priority: Low Type: Enhancement New feature or request labels Nov 14, 2019
@roaldnefs
Copy link
Member

Thanks @flassman for your feature request!

@jbouter
Copy link
Member

jbouter commented Nov 15, 2019

@flassman Thanks for your feature request. As I am lacking the windows knowledge, what range of values can vdata be?

@flassman
Copy link
Author

flassman commented Nov 15, 2019 via email

@roaldnefs
Copy link
Member

This has been fixed been on the SaltStack side in saltstack/salt#56160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants