Fix a bug and add a check in parameters.f90 #258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the
berry_task
check formorb
is wrong inparameters.f90
, while in the previous version ofwannier90
this was correct.I have added a check for
kpoint_path
block since I accidentally encountered a segmentation fault when plotting kpath. The situation is that ifkpath = true
while there is nobegin kpoint_path ... end kpoint_path
block in the input file, thepostw90.x
will complain:compiled with gfortran 8.2.1 on Linux.
I recently implented a new feature of calculating spin Hall conductivity based on wannier90 (https://journals.aps.org/prb/abstract/10.1103/PhysRevB.98.214402). I would like to share my code with the community. If it could be merged into wannier90, I would like to write the corresponding documentaion and tutorials and create a pull request in the next few weeks!