Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution booklet #233

Merged
merged 4 commits into from
Jan 24, 2019
Merged

Conversation

VVitale
Copy link
Collaborator

@VVitale VVitale commented Jan 23, 2019

This adds the solution booklet for examples 1-22 (15 excluded. It will be added shortly). The solutions to the remaining examples will be added ASAP.
The booklet style and layout mirror that of the tutorial.
In the doc directory there is a new folder, called solution_booklet, containing the .tex files and the figures, whereas the compiled pdf is in the compiled_doc folder.

DESCLAIMER: These are the solutions to the 22 examples for the v2.1 of Wannier90!
Also all the band-structures have been computed with ws_distance = .false., which was the default before #218.

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #233 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #233   +/-   ##
========================================
  Coverage    62.01%   62.01%           
========================================
  Files           29       29           
  Lines        17161    17161           
========================================
  Hits         10643    10643           
  Misses        6518     6518

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a6dd86...c22d1cb. Read the comment docs.

@VVitale VVitale requested a review from giovannipizzi January 24, 2019 10:25
@VVitale VVitale added this to the v3.0 milestone Jan 24, 2019
@VVitale VVitale requested a review from jryates January 24, 2019 10:26
@VVitale VVitale mentioned this pull request Jan 24, 2019
18 tasks
Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two leftover files starting with a dot (._...pdf) could you remove them?
Also, I'm wondering if it's worth adding the PDF to the git repository, making it much heavier, or we just keep the sources and put the PDF only on the website. Probably ok to keep it in for now, but we should make this decision also for tutorial and user_guide (I would vote for having these compiled by travis and then pushed automatically e.g. to the GitHub pages).

Copy link
Collaborator Author

@VVitale VVitale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted the two extra .pdf files

Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@giovannipizzi giovannipizzi merged commit 709637c into wannier-developers:develop Jan 24, 2019
@VVitale VVitale deleted the solution_booklet branch January 24, 2019 17:44
manxkim pushed a commit to manxkim/wannier90 that referenced this pull request Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants