Bugfix in SLWF+C from Jae-Mo-Lin. #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ative when using constraints on centres. Moreover, this also acknowledge previous work done by Charles T. Johnson and Radu Miron
Codecov Report
@@ Coverage Diff @@
## develop #206 +/- ##
==========================================
Coverage ? 60.93%
==========================================
Files ? 29
Lines ? 16971
Branches ? 0
==========================================
Hits ? 10341
Misses ? 6630
Partials ? 0
Continue to review full report at Codecov.
|
giovannipizzi
approved these changes
Oct 8, 2018
VVitale
pushed a commit
to VVitale/wannier90
that referenced
this pull request
Oct 8, 2018
…changes from PR wannier-developers#206. Moreover, the userconfig file, jobcongif file and parse_wout.py file have been modified to check the value if Omega IOD_C, Omega Rest, Penalty func and Omega Total_C
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
Bugfix in SLWF+C from Jae-Mo-Lin.
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
…changes from PR wannier-developers#206. Moreover, the userconfig file, jobcongif file and parse_wout.py file have been modified to check the value if Omega IOD_C, Omega Rest, Penalty func and Omega Total_C
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the total spread non-negative when using constraints on centres. Moreover, this also acknowledge previous work done by Charles T. Johnson and Radu Miron in the header of wann_omega and wann_domega