Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distribution of some large matrices in parallel run #173

Merged
merged 4 commits into from
Apr 3, 2018
Merged

distribution of some large matrices in parallel run #173

merged 4 commits into from
Apr 3, 2018

Conversation

hjunlee
Copy link
Contributor

@hjunlee hjunlee commented Mar 27, 2018

Dear developers:

Here are some modifications to distribute some large matrices in parallel run.

They come from my personal version of W90. Since it is more complex than I expected, I aligned the part of my version into the recent version of W90. But, with this version we can deal with the case which requires many k points and bands.

I assume that when gamma_only=T, we use only single core (it is natural since curretnly only k parallelisation is done in W90).

Sincerely,

Hyungjun Lee
EPFL

fix a bug when precond=.true.
@codecov
Copy link

codecov bot commented Mar 28, 2018

Codecov Report

Merging #173 into develop will increase coverage by 0.15%.
The diff coverage is 96.26%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #173      +/-   ##
===========================================
+ Coverage    57.41%   57.57%   +0.15%     
===========================================
  Files           27       27              
  Lines        15572    15624      +52     
===========================================
+ Hits          8941     8995      +54     
+ Misses        6631     6629       -2
Impacted Files Coverage Δ
src/wannierise.F90 75.83% <100%> (-0.23%) ⬇️
src/disentangle.F90 78.8% <100%> (+0.35%) ⬆️
src/parameters.F90 77.55% <100%> (ø) ⬆️
src/postw90/comms.F90 49.55% <87.5%> (+2.51%) ⬆️
src/overlap.F90 76.03% <92.5%> (+2.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc95528...efac5d9. Read the comment docs.

@hjunlee
Copy link
Contributor Author

hjunlee commented Mar 28, 2018

I fixed minor bugs for the case with precond=T; Now all checks have passed.
(Since I am a novice to the github, I didn't know about the automatic checks.)

Sincerely,

Hyungjun Lee
EPFL

Copy link
Member

@jryates jryates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - also tested and proves it fixes know issue with large arrays.

@jryates jryates merged commit da4b9bd into wannier-developers:develop Apr 3, 2018
@hjunlee hjunlee deleted the 180327 branch November 16, 2018 12:42
giovannipizzi added a commit to giovannipizzi/wannier90 that referenced this pull request Jan 22, 2019
manxkim pushed a commit to manxkim/wannier90 that referenced this pull request Jan 10, 2021
distribution of some large matrices in parallel run.  Fixes wannier-developers#171
manxkim pushed a commit to manxkim/wannier90 that referenced this pull request Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants