-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cube format for non-orthogonal cells in plot.f90 #162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
non-orthogonal cells; tested for crystals and molecules (though improvements are certainly possible!); addition of new keyword wannier_plot_scale.
Valerio, Thanks for this. Could you also document the new keyword in the user guide please. |
Hi Jonathan, sorry for the late reply. There is no new keyword to add, but I should probably change the sentence in the user guide where it says that only orthogonal lattice vectors are allowed when using a Gaussian cube format.
… On 16 Jan 2018, at 21:46, Jonathan Yates ***@***.***> wrote:
Valerio, Thanks for this. Could you also document the new keyword in the user guide please.
Jonathan
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#162 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYhIRSmokIHho7IYcM4X4z80fVZExWfyks5tLRi0gaJpZM4RgGyl>.
|
…n cube format can be adopted for systems with non-orthogonal lattice vectors, which can then be displayed with the Vesta visualisation program.
It looks like there is a new input variable called wannier_plot_scale |
Oops, sorry you are absolutely right!
… On 22 Jan 2018, at 11:30, Jonathan Yates ***@***.***> wrote:
It looks like there is a new input variable called wannier_plot_scale
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#162 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYhIRXktY0TsaeMf4fy6yL8wcMGWxx-Aks5tNHFLgaJpZM4RgGyl>.
|
jryates
approved these changes
Jan 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
Previous changes to plot.f90 from Arash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to generate cube files for non orthogonal unit cells