write_u_matrices not written #139
Comments
giovannipizzi
added a commit
to giovannipizzi/wannier90
that referenced
this issue
May 24, 2018
These were used to decide hether to enter the plotting routines. This was causing the `write_u_matrices` to be ignored if there wasn't also another plotting flag active. Now the routine is always called, and inside it there were already the appropriate if statements. This new design should be more future-proof when more plotting modes are added. I only put the header printing within an if, this is in the same file so easier to notice in the future, and anyway even if forgotten will just not print the header. This commit fixes wannier-developers#139
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this issue
Jan 10, 2021
These were used to decide hether to enter the plotting routines. This was causing the `write_u_matrices` to be ignored if there wasn't also another plotting flag active. Now the routine is always called, and inside it there were already the appropriate if statements. This new design should be more future-proof when more plotting modes are added. I only put the header printing within an if, this is in the same file so easier to notice in the future, and anyway even if forgotten will just not print the header. This commit fixes wannier-developers#139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
plot_main()is called only in some cases. Some routines in it, therefore, are sometimes not called (e.g.write_u_matrices).In fact,
write_u_matricesis checked only insideplot_main(), but plot_main is called in wannier_prog.F90 onlyif (wannier_plot .or. bands_plot .or. fermi_surface_plot .or. write_hr).One needs to extend the if statements (or manage the plotting differently). (Plotting of course happens if at least one of the flags is also set in the input).
The text was updated successfully, but these errors were encountered: