Fix typo (opensearch-project#176)

--------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
wanglam · Sep 18, 2023 · e296a5d · e296a5d
1 parent cfa9c4b
commit e296a5d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 17 deletions.
diff --git a/src/plugins/workspace/server/plugin.ts b/src/plugins/workspace/server/plugin.ts
@@ -185,7 +185,7 @@ export class WorkspacePlugin implements Plugin<{}, {}> {
   public start(core: CoreStart) {
     this.logger.debug('Starting SavedObjects service');
     this.permissionControl?.setup(core.savedObjects.getScopedClient);
-    this.client?.setSavedObjectes(core.savedObjects);
+    this.client?.setSavedObjects(core.savedObjects);
     this.setupWorkspaces(core);
 
     return {

diff --git a/src/plugins/workspace/server/types.ts b/src/plugins/workspace/server/types.ts
@@ -36,7 +36,7 @@ export interface IRequestDetail {
 
 export interface IWorkspaceDBImpl {
   setup(dep: CoreSetup): Promise<IResponse<boolean>>;
-  setSavedObjectes(savedObjectes: SavedObjectsServiceStart): void;
+  setSavedObjects(savedObjects: SavedObjectsServiceStart): void;
   create(
     requestDetail: IRequestDetail,
     payload: Omit<WorkspaceAttributeWithPermission, 'id'>

diff --git a/src/plugins/workspace/server/workspace_client.ts b/src/plugins/workspace/server/workspace_client.ts
@@ -33,11 +33,11 @@ export class WorkspaceClientWithSavedObject implements IWorkspaceDBImpl {
 
   private savedObjects?: SavedObjectsServiceStart;
 
-  setSavedObjectes(savedObjects: SavedObjectsServiceStart) {
+  setSavedObjects(savedObjects: SavedObjectsServiceStart) {
     this.savedObjects = savedObjects;
   }
 
-  private getScopeClientWithoutPermisson(
+  private getScopedClientWithoutPermission(
     requestDetail: IRequestDetail
   ): SavedObjectsClientContract | undefined {
     return this.savedObjects?.getScopedClient(requestDetail.request, {
@@ -80,11 +80,13 @@ export class WorkspaceClientWithSavedObject implements IWorkspaceDBImpl {
       const { permissions, ...attributes } = payload;
       const id = generateRandomId(WORKSPACE_ID_SIZE);
       const client = this.getSavedObjectClientsFromRequestDetail(requestDetail);
-      const existingWorkspaceRes = await this.getScopeClientWithoutPermisson(requestDetail)?.find({
-        type: WORKSPACE_TYPE,
-        search: attributes.name,
-        searchFields: ['name'],
-      });
+      const existingWorkspaceRes = await this.getScopedClientWithoutPermission(requestDetail)?.find(
+        {
+          type: WORKSPACE_TYPE,
+          search: attributes.name,
+          searchFields: ['name'],
+        }
+      );
       if (existingWorkspaceRes && existingWorkspaceRes.total > 0) {
         throw new Error(DUPLICATE_WORKSPACE_NAME_ERROR);
       }
@@ -166,14 +168,14 @@ export class WorkspaceClientWithSavedObject implements IWorkspaceDBImpl {
       const client = this.getSavedObjectClientsFromRequestDetail(requestDetail);
       const workspaceInDB: SavedObject<WorkspaceAttribute> = await client.get(WORKSPACE_TYPE, id);
       if (workspaceInDB.attributes.name !== attributes.name) {
-        const existingWorkspaceRes = await this.getScopeClientWithoutPermisson(requestDetail)?.find(
-          {
-            type: WORKSPACE_TYPE,
-            search: attributes.name,
-            searchFields: ['name'],
-            fields: ['_id'],
-          }
-        );
+        const existingWorkspaceRes = await this.getScopedClientWithoutPermission(
+          requestDetail
+        )?.find({
+          type: WORKSPACE_TYPE,
+          search: attributes.name,
+          searchFields: ['name'],
+          fields: ['_id'],
+        });
         if (existingWorkspaceRes && existingWorkspaceRes.total > 0) {
           throw new Error(DUPLICATE_WORKSPACE_NAME_ERROR);
         }