Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show that when benchmarking properly there's no difference #1

Merged
merged 6 commits into from
Apr 9, 2015
Merged

Show that when benchmarking properly there's no difference #1

merged 6 commits into from
Apr 9, 2015

Commits on Apr 9, 2015

  1. Add meta charset to avoid annoying warnings

    @domenic
    domenic committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    5fe6614 View commit details
    Browse the repository at this point in the history

  2. Only create the executor for read once per reader 

    Delta: minor (0.01-ish in all configs)
    @domenic
    domenic committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    e0b97ba View commit details
    Browse the repository at this point in the history

  3. Use Promise.resolve instead of new Promise for reader 

    Delta: -0.2 in Firefox for both Bluebird and native
    @domenic
    domenic committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    0070182 View commit details
    Browse the repository at this point in the history

  4. Add ratio statistic 

    It fluctuates wildly, which is not a good sign for the reliability of this benchmark
    @domenic
    domenic committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    3c8bda0 View commit details
    Browse the repository at this point in the history

  5. Try a less convoluted reader creation 

    This is not really making a difference
    @domenic
    domenic committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    87c1999 View commit details
    Browse the repository at this point in the history

  6. Use benchmark.js 

    With proper benchmarking there's no difference between the two.
    @domenic
    domenic committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    f846cf3 View commit details
    Browse the repository at this point in the history