Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to allow cylinders - and other cuboids - to go down #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kellyfj
Copy link
Contributor

@kellyfj kellyfj commented Jan 11, 2015

Hi Walter,

I was trying to create a new function like cylinder.js but that would create a hole in the ground. I traced cylinder --> arcImpl down to traverseHeight and noticed I could not pass a negative height in.

Would love some feedback on whether this approach makes sense or if you would do something different.

With this change I can now do
/js cylinder(blocks.air,5,-40)

to make a hole with radius 5 and 40 blocks deep

Best,

-Frank

@walterhiggins
Copy link
Owner

Hey @kellyfj ,

If you want to build down, then why not move down first then build up?

/js down(40).cylinder(blocks.air,5,40)

@walterhiggins
Copy link
Owner

hmmm. I think I see what you mean - you can do it by moving the drone first but using negative values for width, height and depth is more concise. I'll look at this some more.

@walterhiggins
Copy link
Owner

I reckon if we go this route (negative distances) we'll have to do it for height, width and depth and update the docs accordingly. Will have a think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants