Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Running web-wallet on Docker #673

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

alegomes
Copy link
Contributor

@alegomes alegomes commented Aug 6, 2024

Description

The README file had instructions about how to build the web-wallet Docker image but no info about how to run it in a Docker container.

I tried to run it with the most simple command possible, but it failed.

docker run -p 7101:7101 waltid/waltid-web-wallet

After some tweaks, it worked. And that's what this PR is all about.

Fix issue #672

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my code
  • [-] If it is a core feature, I have added thorough tests
  • [-] Do we need to implement analytics?
  • [-] Will this be part of a product update? If yes, please write one phrase about this update.
  • My code follows the style guidelines of this project
  • [-] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [-] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • [-] Any dependent changes have been merged and published in downstream modules

@alegomes alegomes linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link

Copy link

sonarcloud bot commented Aug 28, 2024

@SuperBatata
Copy link
Contributor

The structure of the web-wallet is changed to include both front-end wallets (dev and demo) .
You can find more details here : #698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web-wallet not running with Docker
2 participants