Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

643 issuance verification tests for w3c sd jwt #658

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

643 issuance verification tests for w3c sd jwt #658

wants to merge 4 commits into from

Conversation

philpotisk
Copy link
Contributor

@philpotisk philpotisk commented Jul 31, 2024 •
edited by mikeplotean
Loading

Description

Provide a clear and concise description of the changes made in this pull request.

Fixes #643

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@philpotisk philpotisk linked an issue Jul 31, 2024 that may be closed by this pull request
Issuance & verification tests for W3C SD-JWT #643
Open
@mikeplotean mikeplotean force-pushed the 643-issuance-verification-tests-for-w3c-sd-jwt branch from 8fe68ad to 8c281c6 Compare July 31, 2024 18:44
mikeplotean
mikeplotean previously approved these changes Jul 31, 2024
View reviewed changes
@mikeplotean
Copy link
Contributor

will merge after #575, #634 and #610 because of potential merge conflicts

@mikeplotean mikeplotean mentioned this pull request Jul 31, 2024
Open
15 tasks
@mikeplotean mikeplotean force-pushed the 643-issuance-verification-tests-for-w3c-sd-jwt branch 2 times, most recently from a09669d to 0467a7b Compare August 1, 2024 19:54
@mikeplotean mikeplotean force-pushed the 643-issuance-verification-tests-for-w3c-sd-jwt branch 2 times, most recently from 8db32f3 to 3ee139c Compare August 13, 2024 15:24
@mikeplotean mikeplotean self-requested a review August 13, 2024 15:40
mikeplotean
mikeplotean previously approved these changes Aug 13, 2024
View reviewed changes
@mikeplotean mikeplotean force-pushed the 643-issuance-verification-tests-for-w3c-sd-jwt branch from 3ee139c to d3792cc Compare August 14, 2024 11:15
@mikeplotean mikeplotean force-pushed the 643-issuance-verification-tests-for-w3c-sd-jwt branch 3 times, most recently from 503277a to 18153b4 Compare September 2, 2024 15:22
@mikeplotean
Copy link
Contributor

update according to #730

@mikeplotean
feat: sdjwt e2e flows test
b400a4c 
# Conflicts:
#	waltid-services/waltid-e2e-tests/src/test/kotlin/E2ETest.kt

# Conflicts:
#	waltid-services/waltid-e2e-tests/src/test/kotlin/E2ETest.kt

# Conflicts:
#	waltid-services/waltid-e2e-tests/src/test/kotlin/E2ETest.kt

# Conflicts:
#	waltid-services/waltid-e2e-tests/src/test/kotlin/E2ETest.kt

# Conflicts:
#	waltid-services/waltid-e2e-tests/src/test/kotlin/E2ETest.kt
#	waltid-services/waltid-e2e-tests/src/test/kotlin/IssuerApi.kt
@mikeplotean
refactor: sdjwt e2e test, exchange-api, verifier-api
03e5e3f 
# Conflicts:
#	waltid-services/waltid-e2e-tests/src/test/kotlin/E2ETest.kt

# Conflicts:
#	waltid-services/waltid-e2e-tests/src/test/kotlin/E2ETest.kt

# Conflicts:
#	waltid-services/waltid-e2e-tests/src/test/kotlin/E2ETest.kt

# Conflicts:
#	waltid-services/waltid-e2e-tests/src/test/kotlin/E2ETest.kt
@mikeplotean
fix: e2e http-response expect extension functions
072d873 
Signed-off-by: mikeplotean <mike@walt.id>

# Conflicts:
#	waltid-services/waltid-e2e-tests/src/test/kotlin/LspPotentialWallet.kt

# Conflicts:
#	waltid-services/waltid-e2e-tests/src/test/kotlin/AuthorizationCodeFlow.kt
@mikeplotean
fix: merge conflicts
2ca79ef 
# Conflicts:
#	waltid-services/waltid-e2e-tests/src/test/kotlin/ExchangeExternalSignaturesApi.kt
@mikeplotean mikeplotean force-pushed the 643-issuance-verification-tests-for-w3c-sd-jwt branch from 18153b4 to 2ca79ef Compare September 6, 2024 18:08
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeplotean mikeplotean mikeplotean left review comments

@cpatsonakis cpatsonakis Awaiting requested review from cpatsonakis

@waltkb waltkb Awaiting requested review from waltkb

At least 1 approving review is required to merge this pull request.

Assignees

@mikeplotean mikeplotean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issuance & verification tests for W3C SD-JWT
2 participants
@philpotisk @mikeplotean