New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output stream can now be set with $outputStream property #984

Merged

walkor merged 1 commit into walkor:master from luzrain:output_stream

Nov 7, 2023

Contributor

luzrain commented Nov 6, 2023

I found out that $outputStream cannot be changed because the property is protected. I need it in my bundle I'm working on.

Changes:

$outputStream property now public.
Removed outputStream() getter and moved out $outputStream initialization process from the safeEcho() method to new initStdOut() method.
Changed the way how the output decoration support is checked. I borrowed it from the symfony console.
Simplified the resetStd() method and removed the $STDOUT, $STDERR global variables from it.


          Output stream can now be set with $outputStream property

afcc4fd

walkor merged commit 366449d into walkor:master

18 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet