Events finalize #981
Merged
Events finalize #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems it has broken windows-php8.3 test 🤔 It's strange. PS. Just not very stable tests. rerun has solved it. |
luzrain
force-pushed
the
events_finalize
branch
from
4e6ca2a to
32112b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to finalize Event classes. Inheritance for them seems not very much useful and even unwanted since we have Interface. User can implement Interface and use own implementation if it needed instead of inheriting from package implementations.
I believe it's possible now while version 5 is still in beta.
I also suggest to remove getErrorHandler method from Interface since it don't used here.