Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows and Mac Os to tests #951

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Add Windows and Mac Os to tests #951

merged 5 commits into from
Sep 7, 2023

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented Aug 19, 2023

So we'll find problems faster for that OSes.

I think that will be good to also add test for each event-loop system(event, swoole, revolt, ...)

@joanhey
Copy link
Contributor Author

joanhey commented Aug 19, 2023

Seems that exist a problem with Guzzle

image

It's working, but it'll fail in the future.
I'll try to fix it in other PR.

@joanhey
Copy link
Contributor Author

joanhey commented Aug 19, 2023

@walkor if you want, you can merge it in another branch, till we fix the code or tests.
But first merge the PR #950, so we will have the extra info.

@joanhey
Copy link
Contributor Author

joanhey commented Aug 19, 2023

In Mac only fail the unit UdpConnectionTest.

In windows can't install posix and pcntl, and it's normal, but need to pass the test without both
image
And 5 failed tests, that perhaps are from the symfony/process, we need more investigation.
In Adapterman with Workerman 4.1, Windows only fail in the Upload test (investigating).

We can skip tests in Windows/Mac/Linux if it's necessary.
image

@joanhey
Copy link
Contributor Author

joanhey commented Sep 6, 2023

@walkor you can check the Adapterman tests working with Ubuntu, MacOS and Windows. Using the same code and .yml.

https://github.com/joanhey/AdapterMan/actions/runs/6094582441/job/16536405869#step:5:11

We need to update the tests to work. Or mark the tests than never will work with an OS.

@walkor walkor merged commit 7767ef6 into walkor:master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants