Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable tests for java onepointfive #1480

Merged
merged 2 commits into from
Feb 2, 2025
Merged

Conversation

jkhaliqi
Copy link
Contributor

Creates ECJJava15IRTest similar to ECJJava17IRTest in order to test classes using javaonepointfive package.

@msridhar
Copy link
Member

There are multiple similar pull requests trying to make this change, and unfortunately I cannot understand what's going on here. Could you clarify in more detail how this PR is adding new tests? I don't see any new test inputs.

@jkhaliqi
Copy link
Contributor Author

Hey, so we couldn't find how java onepointfive was run before so we added these in to run. cc @juliandolby

@jkhaliqi jkhaliqi changed the title add in tests for java onepointfive run tests for java onepointfive Jan 29, 2025
@jkhaliqi jkhaliqi changed the title run tests for java onepointfive enable tests for java onepointfive Jan 29, 2025
@msridhar
Copy link
Member

@jkhaliqi can we close all the outdated pull requests so we have a single open one with the relevant changes?

@jkhaliqi
Copy link
Contributor Author

@msridhar Thank you, All other PR's closed everything should be updated on this single PR.

msridhar
msridhar previously approved these changes Jan 30, 2025
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Eventually we should rewrite these tests to be parameterized tests rather than extracting things out from the test method name.

@msridhar msridhar enabled auto-merge (squash) January 30, 2025 23:08
Copy link

Test Results

  483 files   -   337    483 suites   - 337   2h 32m 1s ⏱️ - 1h 39m 9s
  765 tests +   21    748 ✅ +   21  17 💤 ± 0  0 ❌ ±0 
3 027 runs   - 2 065  2 957 ✅  - 2 014  70 💤  - 51  0 ❌ ±0 

Results for commit 35ea1b2. ± Comparison against base commit de5b4f3.

@msridhar
Copy link
Member

@jkhaliqi please run ./gradlew spotlessApply to fix the formatting errors and commit the results.

@msridhar msridhar merged commit 1533581 into wala:master Feb 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants