-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable tests for java onepointfive #1480
Conversation
There are multiple similar pull requests trying to make this change, and unfortunately I cannot understand what's going on here. Could you clarify in more detail how this PR is adding new tests? I don't see any new test inputs. |
Hey, so we couldn't find how java onepointfive was run before so we added these in to run. cc @juliandolby |
1af5fe2
to
b510bfc
Compare
@jkhaliqi can we close all the outdated pull requests so we have a single open one with the relevant changes? |
b510bfc
to
35ea1b2
Compare
@msridhar Thank you, All other PR's closed everything should be updated on this single PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Eventually we should rewrite these tests to be parameterized tests rather than extracting things out from the test method name.
@jkhaliqi please run |
Creates ECJJava15IRTest similar to ECJJava17IRTest in order to test classes using javaonepointfive package.