Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter missing messages #2119

Merged
merged 3 commits into from
Sep 2, 2024
Merged

fix: filter missing messages #2119

merged 3 commits into from
Sep 2, 2024

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Aug 31, 2024

Problem

This PR addresses 3 problems:

  • When peer is renewed and it was used in filter subscription it is not added into missing messages hash map.
    Because of that this.addHash fails during processing of incoming messages and that terminates callback's invokation.
  • Because of bug introduced for keep alive feature - pings are not done properly.
  • To be more align with RFC - DEFAULT_MAX_PINGS has to be changed to 2;

Solution

Fix bugs, change const.

Notes

Related bug: #2120
Validated against: @waku/sdk@0.0.28-5459f48.0 in dogfooding app

@weboko weboko requested a review from a team as a code owner August 31, 2024 18:59
Copy link

github-actions bot commented Aug 31, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 82.82 KB (+0.01% 🔺) 1.7 s (+0.01% 🔺) 2.2 s (-39.03% 🔽) 3.9 s
Waku Simple Light Node 134.62 KB (-0.06% 🔽) 2.7 s (-0.06% 🔽) 3.9 s (+36.96% 🔺) 6.6 s
ECIES encryption 22.94 KB (0%) 459 ms (0%) 934 ms (+46.72% 🔺) 1.4 s
Symmetric encryption 22.39 KB (0%) 448 ms (0%) 977 ms (-7.1% 🔽) 1.5 s
DNS discovery 72.38 KB (0%) 1.5 s (0%) 2.5 s (+17.93% 🔺) 3.9 s
Peer Exchange discovery 73.73 KB (0%) 1.5 s (0%) 2.6 s (+22.43% 🔺) 4 s
Local Peer Cache Discovery 67.63 KB (0%) 1.4 s (0%) 2.7 s (+77.52% 🔺) 4 s
Privacy preserving protocols 74.8 KB (0%) 1.5 s (0%) 3.5 s (-4.71% 🔽) 5 s
Waku Filter 78.06 KB (+0.06% 🔺) 1.6 s (+0.06% 🔺) 3.6 s (+26.84% 🔺) 5.2 s
Waku LightPush 75.58 KB (0%) 1.6 s (0%) 1.7 s (-20.3% 🔽) 3.2 s
History retrieval protocols 75.96 KB (0%) 1.6 s (0%) 2.2 s (-9.67% 🔽) 3.7 s
Deterministic Message Hashing 7.38 KB (0%) 148 ms (0%) 385 ms (-10.25% 🔽) 532 ms

@weboko weboko changed the title bug: fix filter missing messages fix: filter missing messages Aug 31, 2024
@weboko weboko merged commit 5d3cc5f into master Sep 2, 2024
13 of 14 checks passed
@weboko weboko deleted the weboko/fix-filter branch September 2, 2024 22:59
@weboko weboko mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants