Add composition of WebPipe's #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It changes something like:
```ruby
plug :hello, with: ->(conn) { conn.put(:hello, 'hello') }
```
to
```ruby
plug :hello, ->(conn) { conn.put(:hello, 'hello') }
```
WebPipe representation as a proc is the composition of all its plug
operations. Thus, it is itself an operation taking a `Conn` and
returning a `Conn`. It can be leveraged to be plugged as any other
operation and compose WebPipe's:
```ruby
class HtmlApp
include WebPipe
plug :html
private
def html(conn)
conn.set_response_header('Content-Type', 'text/html')
end
end
class App
include WebPipe
plug :html, &HtmlApp.new
plug :body
private
def body(conn)
conn.set_response_body('Hello, world!')
end
end
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow composition of WebPipe's
WebPipe representation as a proc is the composition of all its plug operations. Thus, it is itself an operation taking a
Connand returning aConn. It can be leveraged to be plugged as any otheroperation and compose WebPipe's:
This PR introduces a breaking change.
with:is no longer used to specify the operation when plugging. Now it is just the second positional argument: