Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename taint to halt, and clean/dirty to ongoing/halted #25

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

waiting-for-dev
Copy link
Owner

This makes the purpose clearer and avoids overriding Object#taint

Now, instead of Conn::Clean and Conn::Dirty subclasses we have Conn::Ongoing and Conn::Halted. Also, in order to stop the pipe we need to call #halt instead of #taint. A #halted? predicate has been added to Conn.

This makes the purpose clearer and avoids overriding `Object#taint`
@waiting-for-dev waiting-for-dev added the enhancement New feature or request label Aug 2, 2019
@waiting-for-dev waiting-for-dev merged commit 7f23ebd into master Aug 2, 2019
@waiting-for-dev waiting-for-dev deleted the halted branch August 2, 2019 06:15
@timriley
Copy link

timriley commented Aug 2, 2019

I really like these naming changes, @waiting-for-dev :) "Taint", "unclean", etc. raised a lot of negative connotations for me. Ongong/Halted etc. seem both more descriptive and more neutral. Kudos 👏

@waiting-for-dev
Copy link
Owner Author

Thanks @timriley :) Yep, those names were more related to the design principles in the implementation that to the real purpose in this concrete library...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants