Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix middlewares unable to modify a default response #14

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Fix middlewares unable to modify a default response #14

merged 1 commit into from
Jul 25, 2019

Conversation

waiting-for-dev
Copy link
Owner

When response headers or body were not set, the default was a frozen
instance. Consequently, middlewares were unable to modify it using
conventional destructive methods. For example, rack-session was unable
to add SET-COOKIE header because it uses Hash#[].

@waiting-for-dev
Fix middlewares unable to modify a default response
f3dca0a 
When response headers or body was not set, the default was a frozen
instance. Consequently, middlewares were unable to modify it using
conventional destructive methods. For example, `rack-session` was unable
to add `SET-COOKIE` header because it uses `Hash#[]`.
@waiting-for-dev waiting-for-dev merged commit 9f6dcd3 into master Jul 25, 2019
@waiting-for-dev waiting-for-dev added the bug Something isn't working label Jul 25, 2019
@waiting-for-dev waiting-for-dev deleted the frozen_response branch July 26, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@waiting-for-dev