[v3,linux] fix: enable to run natively in wayland #3614
Conversation
WalkthroughThe changes involve updates to the changelog and modifications to the initialization logic in the Linux application code. A new entry in the changelog highlights a fix for native Wayland support, referencing previous pull requests. In the application code, a conditional check is introduced to prevent overwriting the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
stendler
changed the title
|
This looks fine to me. Have you noticed any other artifacts of using wayland backend in the webkit window? |
|
Haven't noticed any issues with wayland so far. Though, I've only used the cgo version. The purego code seems to set |
|
Thanks 🙏 Please could you add an entry to the changelog located at |
|
Done! |
|
Can you please fix the merge conflicts 👍 |
Incorporated from this v2 change: wailsapp#1811
stendler
force-pushed
the
v3/fix-wayland
branch
from
2232ed1
to
18e461b
Compare
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- mkdocs-website/docs/en/changelog.md (1 hunks)
- v3/pkg/application/application_linux.go (1 hunks)
Additional comments not posted (2)
v3/pkg/application/application_linux.go (1)
30-32: Conditional check forGDK_BACKENDis well-implemented.The logic to set
GDK_BACKENDonly when necessary is a robust improvement, preventing potential conflicts with existing environment variable values.mkdocs-website/docs/en/changelog.md (1)
25-25: Changelog entry is clear and informative.The new entry under the "Fixed" section accurately describes the changes and references relevant pull requests, maintaining consistency with the existing format.
|
I've rebased and moved the changelog line to the new unreleased section. Although now I seem to have trouble building on linux (likely due to changes in #3667): WARNING -: # github.com/wailsapp/wails/v3/pkg/application
wails/v3/pkg/application/webview_window_linux.go:383:69: could not determine kind of name for C.GDK_ALL_EVENTS_MASK
wails/v3/pkg/application/webview_window_linux.go:381:69: could not determine kind of name for C.GDK_ENTER_NOTIFY_MASK
wails/v3/pkg/application/webview_window_linux.go:381:93: could not determine kind of name for C.GDK_LEAVE_NOTIFY_MASK
wails/v3/pkg/application/webview_window_linux.go:381:29: could not determine kind of name for C.GtkWidget
wails/v3/pkg/application/webview_window_linux.go:381:3: could not determine kind of name for C.gtk_widget_set_events
WARNING /myapp/wails/v3/pkg/application/application_linux.go:15:8: could not import C (no metadata for C)
WARNING /myapp/wails/v3/pkg/application/webview_window_linux.go:285:25: undefined: options
WARNING /myapp/wails/v3/pkg/application/webview_window_linux.go:381:42: undefined: unsafe
WARNING /myapp/wails/v3/pkg/application/webview_window_linux.go:383:42: undefined: unsafe See also the CI in my fork: https://github.com/stendler/wails/actions/runs/10525939856/job/29165722019#step:6:381 EDIT: I got it to run, but ... (click to expand)in But I could not get the "ignoreMouseEvents" behaviour to work correclty. Neither with the moved implementation, nor with the already existing At least it builds again, and the tests pass: https://github.com/stendler/wails/actions/runs/10530008414 |
Description
Incorporated from this v2 change:
#1811
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor.Verified using
xeyes: if the eyes follow the mouse when entering the wails app window, then it is running on X11; if they stop following when entering the window it is running on wayland.Test Configuration
Checklist:
website/src/pages/changelog.mdxwith details of this PRSummary by CodeRabbit
New Features
Bug Fixes