-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wails dev will fail if GOOS do not match the current system #3592
base: master
Are you sure you want to change the base?
Conversation
…system.(can not build suitable wailsbingings)
WalkthroughThe changes involve updating the Changes
Sequence Diagram(s)No sequence diagrams are necessary for these changes since they do not introduce new features or significantly alter control flow. Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- v2/pkg/commands/bindings/bindings.go (1 hunks)
Additional comments not posted (1)
v2/pkg/commands/bindings/bindings.go (1)
56-60
: Ensure proper handling of environment variables.The changes correctly set
GOOS
andGOARCH
to the current system's environment before running the build command. This ensures that the executable is suitable for the current system, addressing the issue described in the PR summary.
Thanks 🙏 Please could you add an entry to the changelog located at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- website/src/pages/changelog.mdx (1 hunks)
Additional comments not posted (2)
website/src/pages/changelog.mdx (2)
20-20
: Approved: Corrected capitalization for consistency.The change from "windows" to "Windows" ensures proper capitalization of the operating system name.
20-20
: Approved: Documented fix forwails dev
command failure.The addition of this entry documents the fix for the issue where the
wails dev
command fails ifGOOS
andGOARCH
do not match the current system, enhancing clarity and error handling documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- website/src/pages/changelog.mdx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- website/src/pages/changelog.mdx
done |
Description
fix: wails dev will fail if GOOS and GOARCH do not match the current system.(can not build suitable wailsbingings)
When I want to use this, I got a error on
wails dev
. I locate the problem.Fixes #2679 #2277
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration
Please paste the output of
wails doctor
. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdx
with details of this PRSummary by CodeRabbit
wails dev
when the operating system does not matchGOOS
.