[v3] Fix default context-menu in selected disabled inputs #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaanthony
reviewed
Jun 30, 2023
| @@ -28,7 +28,7 @@ func main() { | |||
| mainWindow := app.NewWebviewWindowWithOptions(application.WebviewWindowOptions{ | |||
| Title: "Context Menu Demo", | |||
| Width: 1024, | |||
| Height: 1124, | |||
| Height: 1024, | |||
There was a problem hiding this comment.
I set this to 1124 as all the boxes didn't fit on Windows :-) Do they all fit in Mac?
There was a problem hiding this comment.
I just sized it and then ran wails.Window.Size() in devtools and got this:
height: 1681,
width:1024
There was a problem hiding this comment.
On my screen a little bit was hidden under the windows taskbar, so made it smaller to fit and scrollbars with appear, I don't know how it looks on Mac.
There was a problem hiding this comment.
Ah the joys of different screen resolutions 😅
…ask taskfile:update`.
|
I accidentally pushed some updates to your PR branch 😅 It's all good - we can merge. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processDefaultContextMenu()was missing showing the default context-menu for selected text in a disabled or readonly input, this PR fixes that to be aligned with v2.