Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows tray menus #2181

Merged
merged 5 commits into from
Dec 6, 2022
Merged

Windows tray menus #2181

merged 5 commits into from
Dec 6, 2022

Conversation

leaanthony
Copy link
Member

A leaner PR based on #1959

@leaanthony leaanthony requested a review from stffabi December 5, 2022 08:57
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 5, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 58ca388
Status:⚡️  Build in progress...

View logs

Copy link
Collaborator

@stffabi stffabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the open things regarding the message loops discussed in #1959

@leaanthony leaanthony marked this pull request as ready for review December 6, 2022 09:55
@leaanthony leaanthony merged commit b84a2e5 into master Dec 6, 2022
@leaanthony leaanthony deleted the feature/1521_windows_tray_menus branch December 6, 2022 09:55
@leaanthony
Copy link
Member Author

Thanks for reviewing. I imagine this will evolve over time...

@W1M0R W1M0R mentioned this pull request Sep 18, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants