Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling updates #723

Merged
merged 10 commits into from
Oct 6, 2023
Merged

Tooling updates #723

merged 10 commits into from
Oct 6, 2023

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Oct 1, 2023

  • switches to using ruff with more checks
  • linting
  • updates to python linting/testing dependencies
  • adds Wagtail 5.1 to the test matrix

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (f4e312b) 93.29% compared to head (4c538e0) 92.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   93.29%   92.73%   -0.56%     
==========================================
  Files          47       47              
  Lines        3921     3964      +43     
  Branches      583      587       +4     
==========================================
+ Hits         3658     3676      +18     
- Misses        153      174      +21     
- Partials      110      114       +4     
Files Coverage Δ
wagtail_localize/components.py 85.71% <100.00%> (ø)
wagtail_localize/locales/views.py 97.22% <100.00%> (ø)
wagtail_localize/machine_translators/deepl.py 66.66% <ø> (ø)
wagtail_localize/modeladmin/helpers.py 100.00% <ø> (ø)
wagtail_localize/modeladmin/options.py 93.33% <ø> (ø)
wagtail_localize/modeladmin/tests.py 100.00% <ø> (ø)
wagtail_localize/modeladmin/views.py 98.09% <100.00%> (ø)
wagtail_localize/segments/__init__.py 100.00% <100.00%> (ø)
wagtail_localize/test/settings.py 100.00% <100.00%> (ø)
wagtail_localize/views/convert.py 76.81% <100.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

by passing `DATABASE` in env, we trigger trip up `[gh-actions:env]` from tox.ini, which results in a single test to be run

f
every second counts
@zerolab zerolab merged commit 088a6bc into main Oct 6, 2023
@zerolab zerolab deleted the chore/tooling branch October 6, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants