Async race condition fix - Moved publishing to transaction post-commit

wagtail_localize/models.py

@@ -798,7 +798,7 @@ def create_or_update_translation(
                     self.sync_view_restrictions(original, translation)
 
                     if publish:
-                        page_revision.publish()
+                        transaction.on_commit(page_revision.publish)
 
                 else:
                     # Note: we don't need to run full_clean for Pages as Wagtail does that in Page.save()

wagtail_localize/tests/test_edit_translation.py

@@ -2,6 +2,8 @@
 import tempfile
 import uuid
 
+from unittest.mock import patch
+
 import polib
 
 from django.contrib.admin.utils import quote
@@ -10,6 +12,7 @@
 from django.contrib.contenttypes.models import ContentType
 from django.contrib.messages import get_messages
 from django.core.files.uploadedfile import SimpleUploadedFile
+from django.db import transaction
 from django.test import TestCase, override_settings
 from django.urls import reverse
 from django.utils import timezone
@@ -132,9 +135,10 @@ def setUp(self):
         # Create translations
         self.fr_locale = Locale.objects.create(language_code="fr")
 
-        self.snippet_source, created = TranslationSource.get_or_create_from_instance(
-            self.snippet
-        )
+        (
+            self.snippet_source,
+            created,
+        ) = TranslationSource.get_or_create_from_instance(self.snippet)
         self.snippet_translation = Translation.objects.create(
             source=self.snippet_source,
             target_locale=self.fr_locale,
@@ -168,6 +172,10 @@ def setUp(self):
 
 
 class TestGetEditTranslationView(EditTranslationTestData, TestCase):
+    def setUp(self):
+        with patch.object(transaction, "on_commit", side_effect=lambda func: func()):
+            super().setUp()
+
     def test_edit_page_translation(self):
         response = self.client.get(
             reverse("wagtailadmin_pages:edit", args=[self.fr_page.id])