Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the url field for the project homepage in PyPI #685

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Conversation

thibaudcolas
Copy link
Member

Spotted while doing data analysis of Wagtail packages. url is specifically meant for the project "Homepage", so is more appropriate than adding a project_urls set to "Home".

Spotted while doing data analysis of Wagtail packages. [`url`](https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#url) is specifically meant for the project "Homepage", so is more appropriate than adding a `project_urls` set to "Home".
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (c928f64) 93.09% compared to head (1d5d2c2) 93.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files          47       47           
  Lines        3912     3912           
  Branches      581      581           
=======================================
  Hits         3642     3642           
  Misses        159      159           
  Partials      111      111           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zerolab zerolab merged commit 2f6fcb9 into main Apr 10, 2023
@zerolab zerolab deleted the pypi-metadata-url branch April 10, 2023 18:24
@zerolab
Copy link
Collaborator

zerolab commented Apr 22, 2023

@thibaudcolas I discovered the hard way, that this is not the way when using pyproject.toml

see https://packaging.python.org/en/latest/specifications/declaring-project-metadata/#urls
now reverted

zerolab added a commit that referenced this pull request Apr 22, 2023
@thibaudcolas
Copy link
Member Author

🤦 sorry! I wouldn’t even have considered that the possible metadata was different between different build tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants