Fix string extraction from nullable RichTextField
#621
Conversation
zerolab
force-pushed
the
fix/extract-strings-with-no-value
branch
from
7e6de4d to
e37726b
Compare
zerolab
force-pushed
the
fix/extract-strings-with-no-value
branch
from
e37726b to
96b0107
Compare
| @@ -1,4 +1,4 @@ | |||
| # Generated by Django 4.0.5 on 2022-06-05 11:41 | |||
| # Generated by Django 4.1.1 on 2022-09-23 14:13 | |||
There was a problem hiding this comment.
This isn't a problem with this PR (if it was actually causing a problem, a test would have failed), but just while I am reading this line, a quick note.
For django packages, the recommended practice is to always generate your migrations with the lowest version of django your package is compatible with (which in this case would be 3.2). See https://docs.djangoproject.com/en/4.1/topics/migrations/#supporting-multiple-django-versions for explanation.
There was a problem hiding this comment.
(this matters even less if the migration is for the test app 😄 )
There was a problem hiding this comment.
it doesn't matter as I've made the necessary modifications for the initial migration manually
|
@zerolab great job thxs! |
Fixes #487, and replaces #523
Kudos to @vladox and @Timusan