Fix duplicate locale defintion in TranslatableCreateView template

[ghost]

This PR fixes #579, as it removes the duplicate definition of the "locale" parameter.

The "?locale=" parameter is already attached to the URL in the base template ("modeladmin/create.html"):
{% block form_action %}{{ view.create_url }}{% endblock %}{% if locale %}?locale={{ locale.language_code }}{% endif %}

As a result, it is currently not necessary to override the "form_action" block.

Removing the code ensures that the CreateView works again, and does not fail because of a malformed URL, ending in a 404 error.

[zerolab]

Hey @benmth, thanks for this. Could you please add test for the fix?
This will ensure future changes don't undo the work

[codecov-commenter]

Codecov Report

Merging #580 (4f3af21) into main (23d0bb7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #580   +/-   ##
=======================================
  Coverage   91.55%   91.56%           
=======================================
  Files          47       47           
  Lines        3898     3899    +1     
  Branches      592      592           
=======================================
+ Hits         3569     3570    +1     
+ Misses        186      185    -1     
- Partials      143      144    +1     

Impacted Files	Coverage Δ
wagtail_localize/modeladmin/tests.py	100.00% <100.00%> (ø)
wagtail_localize/views/convert.py	71.62% <0.00%> (ø)
wagtail_localize/wagtail_hooks.py	80.11% <0.00%> (ø)
wagtail_localize/views/edit_translation.py	85.44% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d0bb7...4f3af21. Read the comment docs.

[zerolab]

I tried to replicate the issue locally and cannot, so this most certainly needs test

[ghost]

Hey @zerolab,

i am not very experienced with testing, especially when it comes to Django templates.

Due to little time at the moment, a test from me will therefore unfortunately take some time, because I have to get acquainted first, to be able to deliver something useful.

[ghost]

Hey @zerolab,

again, sorry to keep you waiting.

I found the time to look at it today and was able to expand the tests accordingly.

In doing so, I then also extended the original change to respect Wagtail installations below version 3.0.

If there is still something to do from my side, please just let me know.

[zerolab]

Nice on @benmth!

[zerolab]

version 1.2.1 is now out