Make TranslatableMixin for snippets not required #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The snippets that do not have the TranslatableMixin or any translation features on it do not work at all. This update fixes the "Nonetype" object has no attribute is_shown.
kaedroho
suggested changes
Nov 20, 2020
There was a problem hiding this comment.
Thanks for fixing this! just a comment about a simpler approach that doesn't require a dummy menu item class. Also this needs a test! (test suite for this button is here: https://github.com/wagtail/wagtail-localize/blob/master/wagtail_localize/tests/test_submit_translations.py#L489)
wagtail_localize/wagtail_hooks.py
Outdated
|
|
||
|
|
||
| class DisabledTranslationSnippetActionMenuItem(): | ||
| def is_shown(self, request, context): |
There was a problem hiding this comment.
Might be simpler to move the if issubclass(model, TranslatableMixin): check itself into the is_shown method on RestartTranslationSnippetActionMenuItem and then make the hook always return a RestartTranslationSnippetActionMenuItem?
|
Fixes #265 |
kaedroho
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snippets that do not have the TranslatableMixin or any translation features on it do not work due to an error message (see image below)
This update fixes the "Nonetype" object has no attribute is_shown error.
Here is an error message -