Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Django 5.0 + add FormSubmissionsPanel #473

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

thibaudcolas
Copy link
Member

I believe the only change strictly needed is the one to the requirements’ definition, but I took the time to also update Django settings for v5.0 based on what was deprecated / removed. And updating all the documentation URLs so they’re more "evergreen".

I also added FormSubmissionsPanel to our FormPage (see wagtail/wagtail#11405).

@thibaudcolas thibaudcolas added the dependencies Pull requests that update a dependency file label Jan 2, 2024
@thibaudcolas thibaudcolas marked this pull request as draft January 2, 2024 16:26
@@ -1,4 +1,4 @@
FROM python:3.9-slim
dwFROM python:3.12-slim
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dwFROM python:3.12-slim
FROM python:3.12-slim

@@ -33,7 +33,7 @@ RUN set -ex \
zlib1g-dev \
" \
&& apt-get update && apt-get install -y --no-install-recommends $BUILD_DEPS \
&& python3.9 -m venv ${VIRTUAL_ENV} \
&& python3.12 -m venv ${VIRTUAL_ENV} \
&& pip install -U pip \
&& pip install --no-cache-dir -r /requirements/production.txt \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: would be good to change these to be python3.12 -m pip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants