Add workaround for garbled utf-8 characters on linux #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://github.com/waf/CSharpRepl/issues/261 See original fix in #231 that introduced this problem. Ultimately it's a workaround for a dotnet bug: dotnet/runtime#88343 We can run the "Windows Only" logic on Linux once the above bug is fixed, but there's no ETA for it.
Codecov Report
@@ Coverage Diff @@
## main waf/PrettyPrompt#262 +/- ##
=====================================
Coverage 85.1% 85.2%
=====================================
Files 45 45
Lines 3875 3879 +4
Branches 598 599 +1
=====================================
+ Hits 3301 3307 +6
+ Misses 435 433 -2
Partials 139 139
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262
See #231 that introduced this problem, but is still good behavior that we desire on all platforms.
Ultimately the following .NET bug is making this not work on Linux: dotnet/runtime#88343
We can run the "Windows Only" logic on Linux once the above bug is fixed, but there's no ETA for it.