Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace visualreport by a report that aligns with the rest of GGIR #1173

Closed
vincentvanhees opened this issue Jul 11, 2024 · 1 comment · Fixed by #1239
Closed

Replace visualreport by a report that aligns with the rest of GGIR #1173

vincentvanhees opened this issue Jul 11, 2024 · 1 comment · Fixed by #1239
Assignees

Comments

@vincentvanhees
Copy link
Member

The visual report is known to not match what GGIR does and we warn about this in the documentation, but someone it continues to cause confusion and raise questions. So, the visual report function (plot5) should be replaced to better match the actual classification of GGIR.

Part of the problems are:

  • Wake up classification on first morning after an incomplete night done but not visualised.
  • A lot of functionality duplicated and possible inconsistent with the main GGIR code.
@vincentvanhees
Copy link
Member Author

vincentvanhees commented Aug 7, 2024

Outstanding work:

  • Indicate whether window met inclusion criteria => not logical, because this decision happens afterward
  • Make it easier to skip windows that do not meet inclusion criteria => not logical, because this decision happens afterward
  • Rename function and report to emphasize that it is for QC purposes => now clarified in documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant