Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timegap imputation for ad-hoc csv not working? #1154

Closed
vincentvanhees opened this issue Jun 14, 2024 · 0 comments · Fixed by #1158
Closed

timegap imputation for ad-hoc csv not working? #1154

vincentvanhees opened this issue Jun 14, 2024 · 0 comments · Fixed by #1158

Comments

@vincentvanhees
Copy link
Member

I think this line https://github.com/wadpac/GGIR/blob/master/R/g.getmeta.R#L222

if (params_rawdata[["imputeTimegaps"]] && (dformat == FORMAT$CSV || dformat == FORMAT$GT3X)) {

should be

      if (params_rawdata[["imputeTimegaps"]] && (dformat == FORMAT$CSV ||
                                                 dformat == FORMAT$AD_HOC_CSV ||
                                                 dformat == FORMAT$GT3X)) {

if we want timegap imputation to work for ad-hoc csv data.

It seems this issue emerge with the code revisions at the end of 2023. I have just tested it and with the above edit it seems to work again.
I will prepare a PR in upcoming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant