Add latest spec and spec team members #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinity0
reviewed
Jan 14, 2021
docs/polkadot.rst
Outdated
| @@ -16,3 +16,4 @@ Polkadot | |||
| polkadot/economics | |||
| polkadot/security | |||
| polkadot/Polkadot-Host-Spec | |||
| polkadot/Polkadot-Runtime-Spec | |||
There was a problem hiding this comment.
The existing links are all top-level sections. So it might be better either to put this under a "specifications" directory, or just have 1 specifications page with multiple PDFs linked on it.
There was a problem hiding this comment.
Good point, I will turn this into a specification section instead (i.e. subfolder)
There was a problem hiding this comment.
You forgot to update this to just polkadot/specifications (and rm the previous line with Host-Spec) but otherwise it looks good!
FlorianFranzen
force-pushed
the
spec-update
branch
from
174d56c
to
9835312
Compare
FlorianFranzen
force-pushed
the
spec-update
branch
from
a9f8094
to
cdb85de
Compare
infinity0
approved these changes
Jan 20, 2021
docs/polkadot.rst
Outdated
| @@ -16,3 +16,4 @@ Polkadot | |||
| polkadot/economics | |||
| polkadot/security | |||
| polkadot/Polkadot-Host-Spec | |||
| polkadot/Polkadot-Runtime-Spec | |||
There was a problem hiding this comment.
You forgot to update this to just polkadot/specifications (and rm the previous line with Host-Spec) but otherwise it looks good!
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the following:
Right now @lamafab and my page only contain our names and email addresses. I will it to further PRs to update these.
This a first step towards w3f/polkadot-spec#332 and fixes w3f/polkadot-spec#28. The release cache was implemented in w3f/polkadot-spec#348 and is the basis for this.
This depends on #115 for the embedded PDF to be displayed, as the currently hosted version is still limited to mozillas GitHub Pages.