Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrapping chapter. #389

Merged
merged 7 commits into from
Mar 23, 2021
Merged

bootstrapping chapter. #389

merged 7 commits into from
Mar 23, 2021

Conversation

drskalman
Copy link
Contributor

Closes #135

@drskalman drskalman mentioned this pull request Feb 12, 2021
Closed
8 tasks
@FlorianFranzen FlorianFranzen marked this pull request as draft February 16, 2021 13:02
@FlorianFranzen FlorianFranzen added the specification Additions and Updates to the Specification label Feb 24, 2021
@FlorianFranzen FlorianFranzen requested a review from lamafab March 22, 2021 16:47
@FlorianFranzen FlorianFranzen force-pushed the skalman-bootstrapping branch from f4e8acf to 671deea Compare March 22, 2021 16:51
@FlorianFranzen FlorianFranzen marked this pull request as ready for review March 22, 2021 16:51
@FlorianFranzen
Copy link
Contributor

FlorianFranzen commented Mar 22, 2021 •
edited
Loading

I reworded and extended the chapter a bit and added a few of the missing references.

Code was rebased to fix merger conflict.

@lamafab lamafab mentioned this pull request Mar 22, 2021
Merged
FlorianFranzen
FlorianFranzen approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@FlorianFranzen FlorianFranzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged edits of @lamafab. Looks good enough for a first version. Will go over the references again in #402.

@FlorianFranzen FlorianFranzen merged commit 4fd7f5c into master Mar 23, 2021
@FlorianFranzen FlorianFranzen deleted the skalman-bootstrapping branch March 23, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianFranzen FlorianFranzen FlorianFranzen approved these changes

@lamafab lamafab Awaiting requested review from lamafab

Assignees

@FlorianFranzen FlorianFranzen

Labels
specification Additions and Updates to the Specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spec all tasks that a node needs to accomplish to join Polkadot properly in one chapte
3 participants
@drskalman @FlorianFranzen @lamafab