Anagolay project Idiyanale milestone 2

[woss]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• In case of acceptance, the payment will be transferred to the BTC/ETH payment address provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#719

[woss]

Not sure what is happening with the checks, i followed the guidelines.

[takahser]

See comment ⬇️

[woss]

@takahser suggestion implemented

[takahser]

@woss cool, it worked :)

We will look into your delivery as soon as possible. Please excuse us if this might take longer than usual, we are currently experiencing a bit of a backlog.

[woss]

@woss cool, it worked :)

We will look into your delivery as soon as possible. Please excuse us if this might take longer than usual, we are currently experiencing a bit of a backlog.

thanks, I hope you will do it by Monday because we are hoping to have the announcement published on your announcement day 13th of June😊

[takahser]

@woss unfortunately, most probably this won't be the case. In any way, if you're planning to publish announcements please make yourself familiar with our announcement guidelines before publishing :)

[woss]

@takahser

We did and we got the announcement approved by your team, only waiting for the green light on this :)

[woss]

Hey @cruikshankss I'd like to mention that we fixed a bug in this commit anagolay/w3f-grant-support-repo@5ce0f1c which caused publish service to panic and crash, which was caused by the wasm-pack dependency and their non-deterministic dependency management. We have seen this happening often with wasm-pack and i hope that you will not have many issues after you pull the last changes and do docker-compose down --volumes inside the repo.

If you do have any issues please don't hesitate to contact me so i can help 🙌

[ashlink11]

@woss Sorry for the huge delay. To potentially speed it up for you, I am wondering: are you available for a video call demo today or tomorrow? My timezone is MST (USA).

If not, no worries. Fyi, it usually takes me much longer to understand and test myself (up to a week, or even more). Again, sorry for the delay.

[woss]

Hi @cruikshankss I am Barcelona based which is CET, which means you are 9 hours behind my TZ now. Shall we agree to have a soft plan for a call as soon as you can in the morning? For example, your 9 AM is my 6 PM, if we cannot make it tomorrow then Monday same time?

[ashlink11]

Hi @woss! Thanks for being open to a call so soon! My work hours are 1pm-9pm CET. Shall we plan on 1pm CET tomorrow? What is the best way to contact you to set up a call? My email is ashleyg@web3.foundation if you'd like to set up a google calendar event/google meet

I do have a meeting 2:30-3pm CET tomorrow, but other than that, feel free to choose any time tomorrow!

[woss]

Hi @cruikshankss, those are early hours for you :) email sent with google talk invite

[Noc2]

Just a quick comment here as well:

• There is a todo here that seems to be missing: https://github.com/anagolay/w3f-grant-support-repo/tree/project-idiyanale-phase1_milestone-2#anagolay-cli-workflow-manifest-generation
• Where can find the testing guide on how to run the unit tests: https://github.com/anagolay/w3f-grant-support-repo/tree/project-idiyanale-phase1_milestone-2
• Could you please link directly to the implementation and not just the repo.

[woss]

Dear @Noc2 ,

Just a quick comment here as well:

There is a todo here that seems to be missing: https://github.com/anagolay/w3f-grant-support-repo/tree/project-idiyanale-phase1_milestone-2#anagolay-cli-workflow-manifest-generation

Well spotted, although the context was the Article that was provided. Fixed.

Where can find the testing guide on how to run the unit tests: https://github.com/anagolay/w3f-grant-support-repo/tree/project-idiyanale-phase1_milestone-2

If you refer to the unit tests for the anagolay runtime, you need to clone https://github.com/anagolay/anagolay-chain/tree/w3f-project-idiyanale-phase1_milestone-2 then set it up then run the tests. Nothing different than any other substrate-based chain. The support repo is not meant to provide user with building the runtime, it comes prebuilt.

Could you please link directly to the implementation and not just the repo.

I do not understand this, what do you refer as implementation?

[ashlink11]

I do not understand this, what do you refer as implementation?

Hi @woss, he means a link to the benchmarking and a link to the pallet. Could you please provide a link directly to the pallet code within your codebase? Thank you!

[woss]

I do not understand this, what do you refer as implementation?

Hi @woss, he means a link to the benchmarking and a link to the pallet. Could you please provide a link directly to the pallet code within your codebase? Thank you!

Hi @cruikshankss, i don't understand, you already provided the link and the links to each of the pallets is in the deliverable. The pallets are written in the same way as any other substrate pallet, containing the benchmarking.rs and weights.rs files.

• workflow pallet
• operations pallet
• ALL pallets

[Noc2]

Hi @woss thanks for the quick reply. Currently the table of this pr simply links to the support repo for each deliverable and not to the specific deliverables. For example Substrate module: an_workflow should ideally link to the implementation of the module and not just the support repo.

[woss]

Dear @Noc2 0d946aa as you requested

[Noc2]

Thanks for the update. That was what I was looking for. I’m happy to accept and merge this delivery as soon as @cruikshankss merges her evaluation. I just pinged her.

[Noc2]

Btw. also someone external took a look at your delivery, you can find his notes here: #482

[ashlink11]

Thanks for the update. That was what I was looking for. I’m happy to accept and merge this delivery as soon as @cruikshankss merges her evaluation. I just pinged her.

Thanks @Noc2. I've merged my eval.

[Noc2]

I’m happy to confirm that the milestone is accepted. I suggest to wait with the payment for now, because of w3f/Grants-Program#1010

[fededubbi]

Good morning @woss,

Please see the following link for payment confirmation:

https://etherscan.io/tx/0x93f383bfd58e98dc03b1567edf615aaeee99b8d50949d8f346fd4c3de83ff4b3

Please let us know if you received the payment.

Many thanks,
Federica

[woss]

Good day @fededubbi , i acknowledge that i have received the payment. Thank you