Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBrush follow-up delivery milestone 4 #385

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

0xMarkian
Copy link
Contributor

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#621

We have changed the ERC20 address, here is the pull request for it - w3f/Grants-Program#850

@alxs
Copy link
Contributor

alxs commented Mar 2, 2022

Thanks for the delivery @0xMarkian. We'll look into it as soon as possible.

Co-authored-by: Aleixo Sanchez <15819210+alxs@users.noreply.github.com>
@semuelle semuelle assigned alxs and semuelle and unassigned alxs Mar 8, 2022
@semuelle
Copy link
Member

Hi @0xMarkian. I am reviewing your delivery and seem to be unable to compile it. I am getting a bunch of Couldn't open temporary storage: No such file or directory error messages, as shown below. Am I supposed to use a specific branch/commit or toolchain version?

❯ yarn build
yarn run v1.22.15
$ npx redspot compile
compiler version: 0.17.0
toolchain: nightly
ink: 32 matches

===== Compile lending_contract =====

 [1/5] Building cargo project
    Updating git repository `https://github.com/paritytech/ink`
    Updating crates.io index
   Compiling contracts v1.4.0 (/openbrush/openbrush-contracts/contracts)
error: custom attribute panicked
  --> /openbrush/openbrush-contracts/contracts/traits/access_control/mod.rs:16:1
   |
16 | #[brush::trait_definition]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: message: Couldn't open temporary storage: No such file or directory (os error 2)

error: custom attribute panicked
  --> /openbrush/openbrush-contracts/contracts/traits/flashloan/mod.rs:16:1
   |
16 | #[brush::trait_definition]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: message: Couldn't open temporary storage: No such file or directory (os error 2)

...

@xgreenx
Copy link
Contributor

xgreenx commented Mar 11, 2022

Hi, thanks for the report!
Some users also experience that issue in Ubuntu. The fix is already merged:
Supercolony-net/openbrush-contracts#83

@TtomaS7
Copy link
Contributor

TtomaS7 commented Mar 14, 2022

Hey!
We are waiting for your review, @semuelle

@semuelle semuelle changed the title OpenBrush follow-up delivery milestone 2(4 milestone for OpenBrush) OpenBrush follow-up delivery milestone 4 Mar 14, 2022
@semuelle
Copy link
Member

Hi @0xMarkian & @xgreenx. Thank you for the quick fix. I was able to compile and run all unit and integration tests without any further hiccups. Kudos to you for all the effort you have put into generalising the contracts and creating, implementing the standards and providing documentation.

Your milestone is hereby accepted. I will forward your invoice for processing.

@semuelle semuelle merged commit 39e7e7e into w3f:master Mar 14, 2022
@RouvenP
Copy link

RouvenP commented Mar 22, 2022

Hi @0xMarkian @xgreenx @TtomaS7, we transferred the payment today. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants