Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openbrush milestone 2 delivery #261

Merged
merged 5 commits into from
Sep 6, 2021
Merged

Conversation

0xMarkian
Copy link
Contributor

@0xMarkian 0xMarkian commented Aug 24, 2021

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#497

@semuelle semuelle self-assigned this Aug 25, 2021
@semuelle
Copy link
Member

Thank you for the delivery. We will look into it as soon as possible.

@0xMarkian
Copy link
Contributor Author

thanks, @semuelle, looking forward!

@takahser
Copy link
Contributor

takahser commented Sep 2, 2021

@themarkian unfortunately the links to the Testing prerequesites (ink! toolchain, Start the node with contract-pallet) on your README are broken

@xgreenx
Copy link
Contributor

xgreenx commented Sep 2, 2021

Thanks for the comment, fixed=)

@takahser
Copy link
Contributor

takahser commented Sep 2, 2021

I just ran the unit tests: cargo test. Unfortunately they are failing on my machine:
image

@xgreenx
Copy link
Contributor

xgreenx commented Sep 2, 2021

You are right, and it fails during the first build. The fix is submitted. Could you try the latest main please? If everything is good, we will create a 1.0.1 release.

@takahser
Copy link
Contributor

takahser commented Sep 3, 2021

@xgreenx tests are green now, thx for fixing. 👍🏽 Are you planning to use any github-integrated CI-pipeline in the future to prevent this from happening again?

@xgreenx
Copy link
Contributor

xgreenx commented Sep 3, 2021

Yea, we plan to add more tests for macros in the next milestone and set up CI as part of it.

@mmagician
Copy link
Contributor

@themarkian Congratulations on completing the second milestone! The full evaluation can be found here.

@mmagician mmagician merged commit 7f9b65b into w3f:master Sep 6, 2021
@0xMarkian
Copy link
Contributor Author

Hey @mmagician!
Thanks a lot. We appreciate your recognition!

Wondering if you have an ETA of an invoice payment?

@mmagician
Copy link
Contributor

I have already approved the invoice, hopefully it should get paid tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants