EraPointsJob: ensure reliable and correct retrieval of era points #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianFranzen
force-pushed
the
patches/active_era
branch
2 times, most recently
from
61af60a to
549c200
Compare
Co-authored-by: penumbra23 <glbranimir@gmail.com>
FlorianFranzen
force-pushed
the
patches/active_era
branch
from
549c200 to
cecba8b
Compare
|
Rebased on stagging. |
ironoa
approved these changes
May 14, 2024
|
Looks good, Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains to fixes that probably should be applied together.
findEraBlockHashchecks theactiveErainstead ofcurrentEra, just as it does inside offindEraBlockNumber.EraPointsJobuses the state from the next era, ensuring the retrieved era points were actually fully computed.These two combined now ensure that the backend consistently retrieves the correct era rewards, without it would either fail (hash to early) or retrieve half computed scores.