-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TAG review for CSS Typed OM #223
Comments
I've started reading through the spec and filing some issues; I haven't gotten that far yet, though, but I plan to continue. |
I'd also note that some of the open issues already pointed out in the spec are reasonably serious, such as pointing out that parts of the spec aren't written yet. That's a bit of an obstacle to getting interoperable implementations. Hopefully these will get sorted out, though. |
Thanks for starting a review! Yes, we are hoping to resolve these issues by the end of this week. |
(In particular, I'm in Sydney for the week specifically to burn thru the issues list.) |
FYI, there's a Intent to Ship: CSS Typed OM on blink-dev which links here. @dbaron, do you expect to file more issues? (I see issues from 2 and 4 days ago, not clear if the latest was the last.) |
I'm hoping to file more (or at least, hoping to read more of the spec), perhaps this afternoon. It's a pretty big spec! |
Sound good, thanks! |
Taken up at London F2F. |
Per conversation at F2F, the motivation and design tradeoffs need to be documented. An Explainer or use-cases doc would resolve. |
Note that whatwg/webidl#345 is worth reviewing here too. In particular the introduction of new objects that require a JavaScript |
@slightlyoff - I have a PR for an explainer out here, in case you want to take a look. Sorry it wasn't part of the original design review. @foolip I will update the intent to ship thread once this is committed. |
Thank you for the explainer! |
@annevk, is #223 (comment) addressed at all by this change? If not, which objects are the relevant ones? |
We're starting to review at the London F2F; some stream-of-consciousness questions:
Thanks! |
@dbaron all objects that use getter/setter: CSSUnparsedValue, CSSNumericArray, and CSSTransformValue. See also whatwg/webidl#100 about more clearly marking getter/setter as legacy in IDL. |
@annevk: this doesn't appear to require an proxy in implementations. Here's the Chrome code (auto-gen'd binding output), e.g. |
@slightlyoff implementations have shortcuts, sure. This is assuming we'd use actual JavaScript to represent these objects, as per the extensible web principles. |
Also, my objection is not that they require proxies were they to be implemented in JavaScript, my objection is that we've been explicitly asked to avoid introducing any such objects going forward by TC39. |
@slightlyoff in response to your questions:
Nope, it should be exposed to the Paint API only. Filing an issue on typed om: w3c/css-houdini-drafts#632
The example seems incorrect - it should be checking
IIUC: when you read values of
The CSSWG resolved to have it be a function, IIRC. For reasons:
I don't understand the question here. Could you elaborate?
Exposing a tokenizer was delayed to a Level 2 spec. Context here: w3c/css-houdini-drafts#193
IIUC. No, the
Since there is a lot of discussion about this, I am filing an issue to track the discussion: w3c/css-houdini-drafts#634
|
@annevk can you link to any reference documenting the level of consensus on that? Is there a recommended alternative way already defined to achieve a similar design to existing web platform APIs (like TouchList)? Without there being a viable alternative ready today, I don't think I can reasonably deny requests to ship additional such APIs in blink. |
I'm still concerned about seeing progress in w3c/css-houdini-drafts#718, but we're going to close this issue at this point because we don't feel we need to cycle back to it for further TAG discussion. Thanks for requesting TAG review. |
Hello TAG!
I'm requesting a TAG review of:
We'd prefer the TAG provide feedback as (please select one):
The text was updated successfully, but these errors were encountered: