-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Human-readable "name" has i18n problem - rely on "title"/"titles" in Thing instead? #630
Comments
Other ways to deal with this:
I'll create a PR for now based on adding "supportLanguage" but we can discuss these other options here. |
name should be kind of identifier and there should be no language variations. |
This feels like classic overengineering to me. I would define the "name" field as a (non-unique) identifier in the default language. |
Yes, but the point is the default language can change due to content negotiation, which will screw up rendering. Anyhow, I've just prepared a PR and we can decide to use it or not. But it's a potential problem that could easily arise in multilanguage contexts. And we can fix it. Or not. |
Oh darn, got it! When dynamically generating a TD for a certain language, that language might be different from the name chosen... |
we should drop I know it is big change |
Yes, a big chance at this point, but I also think we need to, as it is basically an i18n issue. We stuck to Introducing Making Having |
@mmccool , can we agree on dropping the supportLanguage feature and rename this issue to reflect the issue with a non-internationalized name? |
Sure, can drop supportLanguage; using title/titles seems like a good solution to me, as well as making "support" an anyURI. I can include both those changes in my PR, but I'll have to do it tomorrow (it's very late in the evening here and I'll screw it up if I do it now). I will update the title of this issue. |
Title changed. Sorry it's so long, I'm out of brain cells right now. |
Created this, too: #633. This makes support an anyURI. |
Can we collect +1s for going for I am in favor (see #630 (comment)) |
Re title/titles in Thing: +1, in favor. Also, to repeat myself, +1 for support being an anyURI. |
title/titles in Thing: +1 |
+1 regarding renaming "name" to "title" plus "titles", and also +1 for changing type of "support" to anyURI. |
FYI: We are not renaming, we are kicking |
Address issue #630 (remove name from Thing level, add title + titles, support is typed to anyURI)
"titles" in Thing class is optional (for issue #630)
I just made changes so that "titles" is now optional while "title" stays mandatory. |
We had this one open as long as possible for the group to review and comment. Since no concerns were raised, I am closing this issue now. Note that this is not an issue opened by the I18N WG. |
If the default language is changed, for example as part of HTTP negotiation returning text for title and description using an alternative language, then the interpretation (and potentially display, eg in a web dashboard) of "name" and "support" (in case the value of "support" is a person's name, for example) will get broken if "name" and "support" are written using a language with a text direction opposite to that of the (new) default language.
I think we need an alternative mechanism for specifying a language explicitly for "name" and "support" that overrides the default language, since the idea is that these strings are immutable and should always be displayed the same way, including language and text direction.
I suggest adding an optional "supportLanguage" name/value to the Thing object. This would would have a BCP47 language tag as a value (potentially with a script subtag, as needed to specify the direction unambiguously) to specify the language for "name" and "support". This would override any default language specified by any other means for those two strings only, whether the default language was specified using
@language
or through protocol negotiation.It would be optional, however, and if not present the values of "name" and "support" would be interpreted according to the default language.
In the interest of time, I will prepare a PR based on top of my text direction PR, then we can discuss.
The text was updated successfully, but these errors were encountered: