Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify BFCache interaction #500

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

nidhijaju
Copy link
Member

@nidhijaju nidhijaju commented Apr 25, 2023

The proposal for WebTransport interacting with BFCache is that we allow pages using WebTransport to enter the BFCache, but close the connection when navigating away. Then, the various promises will resolve if/when the page is navigated back to.

The spec currently already terminates the session in the unloading document cleanup steps, but this PR adds a step to queue a network task to run cleanup on a WebTransport object. The network task queue will be paused when the page is navigated away from, and resumed when the page is navigated back to.

Fixes #326.

cc @rakina


Preview | Diff

@nidhijaju nidhijaju requested a review from ricea April 25, 2023 12:28
@jan-ivar jan-ivar merged commit ef93226 into w3c:main Apr 25, 2023
github-actions bot added a commit that referenced this pull request Apr 25, 2023
SHA: ef93226
Reason: push, by jan-ivar

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@rakina
Copy link
Member

rakina commented Apr 26, 2023

Thanks for working on this! This is great, but recently the guidance on adding unloading document cleanup steps had changed, so instead of using the hook like this PR does, to define a stand-alone set of steps, that the HTML spec explicitly calls out to. This makes the ordering of the steps clear for all things that run at unloading-document-cleanup time.
(The BFCache guide was recently updated to reflect this as well)

So I think there are some more changes needed:

  1. Instead of defining "unloading document cleanup steps" for HTML make it an independent thing (you can keep the name, or use "context cleanup steps" like the section heading says.
  2. Update the HTML spec to call out to this step in the Web Transport spec from within the HTML spec's "unloading document cleanup steps"

Also, are there any implementation bugs filed for Chrome (and maybe Firefox) yet?

(thanks again!)

cc @domenic @fergald

@nidhijaju nidhijaju deleted the bfcache-wt-interaction branch April 26, 2023 03:15
@fergald
Copy link

fergald commented Nov 19, 2024

Ping any progress on this? I would really like WT to have it's BFCache story straight from the start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Determine interaction with back forward cache
5 participants