Use AbortSignal's abort reason to abort SendStream #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutakahirano
reviewed
Dec 2, 2021
|
ylafon marked as non substantive for IPR from ash-nazg. |
yutakahirano
approved these changes
Dec 3, 2021
github-actions bot
added a commit
that referenced
this pull request
Dec 3, 2021
SHA: 3ddc1a8 Reason: push, by @yutakahirano Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update spec as
WritableStreamDefaultController.abortReasonwas removed in whatwg/streams#1177, and AbortSignal now has an "abort reason" property (i.e.signal.reasonbased on whatwg/dom#1027) that can be used instead for aborting a SendStream.@yutakahirano Is it okay if you could take a look?
Preview | Diff