-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add steps to clear [[CandidatePairs]] in response to ICE restart #196
Comments
Clearing of [[CandidatePairs]] during an ICE restart is not explicitly covered by the existing steps, but it aught to be. An ICE restart causes the ICE agent to discard existing candidate pairs, regather candidates and re-form check lists. From RFC 8445 section 9:
Or even more detailed from RFC 5245 section 9.3.1.1:
When candidates are regathered and candidate pairs are formed again after an ICE restart, [[CandidatePairs]] will be populated with the new pairs and So [[CandidatePairs]] should certainly be cleared beforehand. But also for the sake of consistency and continuity in the application, The current language in the spec for firing of The spec should also make it clear that the event is not cancelable in the event of an ICE restart. On a related note, |
Filed as a follow-up to this comment. The reason why I filed it is I'm not sure whether or not this is already covered by existing ICE pair removal steps.
If it is already covered, then restarting ICE would trigger removing all candidate pairs, and
icecandidatepairremoved
fires for all of them. This might also mean that the app has an opportunity to cancel the removal, depending on if they are cancelable?If it is not covered, then we should probably say to queue a task to remove all ICE candidate pairs, in which case we need to decide whether or not
icecandidatepairremoved
should fire and whether or not they are cancelable.The text was updated successfully, but these errors were encountered: