Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support async iterable<> #365

Merged
merged 4 commits into from
Aug 7, 2019
Merged

feat: support async iterable<> #365

merged 4 commits into from
Aug 7, 2019

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Jul 15, 2019 •
edited
Loading

And add no-console 😱

Implements whatwg/webidl#720

@saschanaz saschanaz requested a review from marcoscaceres July 15, 2019 23:42
@saschanaz
Copy link
Member Author

Probably should split some of this if the actual merge takes some more time.

marcoscaceres
marcoscaceres approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

test/invalid/idl/async-iterable-single.webidl Show resolved Hide resolved
@marcoscaceres marcoscaceres mentioned this pull request Jul 16, 2019
Merged
@saschanaz saschanaz mentioned this pull request Jul 19, 2019
Merged
@marcoscaceres marcoscaceres merged commit cf8caf5 into gh-pages Aug 7, 2019
@marcoscaceres
Copy link
Member

Merged in WebIDL 🥳

@saschanaz saschanaz deleted the async-iterable branch August 7, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschanaz @marcoscaceres