Allow passing a BigInt64Array/BigUint64Array to getRandomValues #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyGu
reviewed
Jul 2, 2021
lucacasonato
added a commit
to lucacasonato/deno
that referenced
this pull request
Jul 19, 2021
Relevant spec change: w3c/webcrypto#266
lucacasonato
added a commit
to lucacasonato/deno
that referenced
this pull request
Jul 19, 2021
Relevant spec change: w3c/webcrypto#266
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
|
@sleevi can you rubberstamp? @dontcallmedom who else can review here? |
lucacasonato
added a commit
to denoland/deno
that referenced
this pull request
Jul 19, 2021
Relevant spec change: w3c/webcrypto#266
tniessen
approved these changes
Jul 19, 2021
dontcallmedom
approved these changes
Jul 19, 2021
|
👍 Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #255 by adding BigInt64Array and BigUint64Array to the list of allowed types in
crypto.getRandomValues(). In addition, don't refer to them as "integer type" but simply list all the allowed types, as per #255 (comment).