Themeing #54
Merged
Themeing #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangdm
commented
Sep 5, 2022
| @@ -141,9 +141,9 @@ <h3>Table of Contents</h3> | |||
| </tr> | |||
| <tr> | |||
| <th><a href="#themeing">Themeing</a></th> | |||
| <td><a href="https://github.com/WICG/webcomponents/issues/864">WICG/webcomponents#864</a></td> | |||
| <td></td> | |||
There was a problem hiding this comment.
What's the priority level for this?
There was a problem hiding this comment.
Yeah, I was thinking that maybe we drop that column for this year's report? In favor of our new outline sections per #53 .
alangdm
commented
Sep 5, 2022
reports/2022.html
Outdated
| @@ -141,9 +141,9 @@ <h3>Table of Contents</h3> | |||
| </tr> | |||
| <tr> | |||
| <th><a href="#themeing">Themeing</a></th> | |||
There was a problem hiding this comment.
A bit late to ask this, but should it be "Themeing" or "Theming"?
There was a problem hiding this comment.
Yeah, it probably should be the latter; Theming.
thescientist13
approved these changes
Sep 5, 2022
|
@thescientist13 for the time being I corrected the theming spelling, thanks for the clarification |
|
@alangdm |
|
@thescientist13 |
github-actions bot
added a commit
that referenced
this pull request
Sep 12, 2022
SHA: 4ac4ca7 Reason: push, by @Westbrook Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Sep 12, 2022
SHA: 4ac4ca7 Reason: push, by @Westbrook Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial draft for themeing
I tried to summarize the most recent thread + the previous conclusion on why ::theme was dropped in the first place.
I have a couple of questions that I added as comments to this PR, if anyone can clarify those please do so