Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructable Stylesheets #50

Merged
merged 3 commits into from
Sep 4, 2022

Conversation

thescientist13
Copy link
Collaborator

Initial draft for constructable stylesheets.

I think I did a relatively good job tracking down links and breadcrumbs, but not sure if summarization is thorough enough, so definitely please let me know if I am missing anything critical.

@thescientist13 thescientist13 changed the title constructable stylesheets initial draft Constructable Stylesheets Aug 28, 2022
reports/2022.html Outdated Show resolved Hide resolved
</ul>
<p>From their standards position tracker, Safari has highlighted some of the following concerns:</p>
<ul>
<li>Issues related to <a href="https://github.com/WICG/construct-stylesheets/issues/45" target="_blank">race conditions</a> with adopting stylesheets and if the adoptedStyleSheets array should be directly mutable or not</li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this one had been worked out... 🫠

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I could have read it wrong or maybe a resolution wasn't communicated? So feel free keep me honest here but those were the breadcrumbs I followed from the Safari positions repo. 👀

Co-authored-by: Westbrook Johnson <westbrook.johnson@gmail.com>
@EisenbergEffect
Copy link
Collaborator

EisenbergEffect commented Sep 1, 2022

Here's the link to what Chromium is using as their IDL for adoptedStyleSeets: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/document_or_shadow_root.idl;l=28. Under the hood, the ObservableArray is implemented as a V8ObservableArrayCSSStyleSheet. I haven't looked into the Firefox implementation. I do know that the property is settable in both Chromium and FF today, which is represented in the IDL linked above. I don't know if that was fully agreed upon though.

Copy link
Collaborator

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You mentioned wanting to add one thing in today's meeting, so I'll leave this open in case you want to do that here. If not, merge away!

@thescientist13
Copy link
Collaborator Author

Ah yeah, I think that might have been related to DSD, so will put up another PR for that.

@thescientist13 thescientist13 merged commit 015934f into main Sep 4, 2022
@thescientist13 thescientist13 deleted the report-2022-constructable-stylesheets branch September 4, 2022 16:29
github-actions bot added a commit that referenced this pull request Sep 4, 2022
SHA: 015934f
Reason: push, by @thescientist13

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Sep 4, 2022
SHA: 015934f
Reason: push, by @thescientist13

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants