Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AudioDataInit.transfer #688

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Add AudioDataInit.transfer #688

merged 1 commit into from
Jul 6, 2023

Conversation

Djuffin
Copy link
Contributor

@Djuffin Djuffin commented Jun 21, 2023

This should allow to avoid extra copies while constructing AudioData from audio samples

Addressing: #104


Preview | Diff

@Djuffin
Copy link
Contributor Author

Djuffin commented Jun 21, 2023

The same as #676 but for AudioData

@Djuffin
Copy link
Contributor Author

Djuffin commented Jun 24, 2023

@padenot could you take a look, this is very similar to what's been done for VideoFrame.

@aboba aboba merged commit a86fb92 into w3c:main Jul 6, 2023
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2023
SHA: a86fb92
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Djuffin Djuffin deleted the transfer branch July 7, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants